fix: signMessage #118
Closed
fix: signMessage #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this PR @chichke , This is being reviewed right now. We'll merge it soon. |
|
@chichke Thanks for contributing. I will close this PR since we have checks to change the changelog file too and thats what was missing but as you know already I have another PR waiting to merge hence added those fixes on the signTypedData PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sign message rpc parameters should be in the correct order according to the rpc documentation msg params should always be first
Types of changes
What types of changes does your code introduce?
Further comments (optional)
web3auth integration doesn't work anymore without this fix