Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature proposal: Integrate dependency support](https://github.com/actions/setup-python/issues/77#issue-593687811) #10

Open
Create-action opened this issue Jan 23, 2024 · 1 comment
Assignees
Labels
feature request New feature or request to improve the current logic help wanted Extra attention is needed needs eyes
Milestone

Comments

@Create-action
Copy link
Collaborator

I think a most users of this action run an "install dependencies" step immediately after. I think it would improve the developer experience if the "install dependencies" step was integrated into this action.

Current workflow:

    - name: Set up Python ${{ matrix.python-version }}
      uses: actions/setup-python@v1
      with:
        python-version: ${{ matrix.python-version }}
    - name: Install dependencies
      run: |
        python -m pip install --upgrade pip
        pip install -r requirements.txt

Option 1: Support installing packages with pip

    - name: Set up Python ${{ matrix.python-version }}
      uses: actions/setup-python@v1
      with:
        python-version: ${{ matrix.python-version }}
        pip-install: -r requirements.txt

        # or if you use a different package manager...
        # pip-install: pipenv
    # - name: Install dependencies
      # run: pipenv install

Option 2: Add full support for all package managers

    - name: Set up Python ${{ matrix.python-version }}
      uses: actions/setup-python@v1
      with:
        python-version: ${{ matrix.python-version }}
        # Pip
        package-manager: pip
        package-manager-args: -r requirements.txt
        # Pipenv
        package-manager: pipenv
        package-manager-args: --pre --dev --deploy
        # Poetry
        package-manager: poetry
        package-manager-args: --no-dev

What do you think? Option 1 is much smaller in scope than option 2, but I think both would be low maintenance (Python has a lot of package managers, but not that many).

@Create-action Create-action added help wanted Extra attention is needed needs eyes feature request New feature or request to improve the current logic labels Jan 23, 2024
@Create-action Create-action added this to the help wanted milestone Jan 23, 2024
@Create-action Create-action self-assigned this Jan 23, 2024
Copy link

Could not create branch issue-10-_Feature_proposal_Integrate_dependency_support_https_//github_com/actions/setup-python/issues/77#issue-593687811 due to: refs/heads/issue-10-Feature_proposal_Integrate_dependency_support_https//github_com/actions/issues/77#issue-593687811 is not a valid ref name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic help wanted Extra attention is needed needs eyes
Projects
None yet
Development

No branches or pull requests

1 participant