From 078e335a9c3450de2cc9afa1d74e34286c1b9cfb Mon Sep 17 00:00:00 2001
From: Barnabas Busa <busa.barnabas@gmail.com>
Date: Mon, 1 Jul 2024 14:46:58 +0200
Subject: [PATCH] fix workflow only run discord if secret present nightly

---
 .github/workflows/nightly.yml | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index 2d5415dbc..5cb247fc4 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -41,8 +41,17 @@ jobs:
             echo "Skipping ./.github/tests/mix-with-tools-mev.yaml"
           fi
 
+      - name: Check if Discord Webhook is Set
+        id: check_discord_webhook
+        run: |
+          if [ -z "${{ secrets.DISCORD_WEBHOOK }}" ]; then
+            echo "discord_webhook_set=false" >> $GITHUB_ENV
+          else
+            echo "discord_webhook_set=true" >> $GITHUB_ENV
+          fi
+
       - name: Notify
-        if: cancelled() || failure()
+        if: (cancelled() || failure()) && env.discord_webhook_set == 'true'
         uses: Ilshidur/action-discord@master
         env:
           DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }}
@@ -54,12 +63,11 @@ jobs:
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v4
-      - name: Extract branch name
-        shell: bash
-        run: echo "branch=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" >> $GITHUB_OUTPUT
-        id: extract_branch
       - name: Kurtosis Assertoor GitHub Action
         uses: ethpandaops/kurtosis-assertoor-github-action@v1
         with:
-          ethereum_package_branch: ${{ steps.extract_branch.outputs.branch }}
+          kurtosis_extra_args: "--image-download always --non-blocking-tasks --verbosity DETAILED"
+          ethereum_package_branch: ""
           ethereum_package_args: .github/tests/mix-assert.yaml
+          ethereum_package_url: "$GITHUB_WORKSPACE"
+          persistent_logs: "true"