Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support swift 5 #16

Closed
wants to merge 3 commits into from
Closed

Support swift 5 #16

wants to merge 3 commits into from

Conversation

danielrobleM
Copy link
Collaborator

@danielrobleM danielrobleM commented Dec 18, 2019 •
edited
Loading

This change fix issue introduced in PR-15 , error on pod spec lint.

Error description:
swift_versions (5.0) compared to the one present in your .swift-version file (4.2).

@danielrobleM
Copy link
Collaborator Author

@etoledom not sure about to change version to 0.4.1 🤔. Let me know

etoledom
etoledom reviewed Dec 18, 2019
View reviewed changes
Copy link
Owner

@etoledom etoledom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the pod spec lint error:

Please remove the .swift-version file which is now deprecated and only use the swift_versions attribute within your podspec.

Sounds better approach to just remove this file.
Could you please update with this change?

Thank you! 🙏

@etoledom
Copy link
Owner

@etoledom not sure about to change version to 0.4.1 🤔. Let me know

I like that idea! We can do this as a hot-fix. Let's do it :)

@danielrobleM danielrobleM changed the title Change version to swift 5 Hotfix/0.4.1 Dec 18, 2019
danielrobleM
danielrobleM commented Dec 18, 2019
View reviewed changes
Example/Pods/Pods.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etoledom I am using xcode 11.3 (11C29).
Not sure why these get generate now (https://stackoverflow.com/questions/49564513/new-file-created-in-xcode-9-3-wsname-xcworkspace-xcshareddata-ideworkspaceche)

@danielrobleM danielrobleM changed the title Hotfix/0.4.1 Support swift 5 Dec 18, 2019
@danielrobleM
Copy link
Collaborator Author

Move to #17

@danielrobleM danielrobleM deleted the feature/support_default_swift_5 branch December 18, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielrobleM @etoledom