Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum call stack size exceeded on refresh #124

Closed
Enzo-bianchi opened this issue Mar 6, 2022 · 1 comment
Closed

Maximum call stack size exceeded on refresh #124

Enzo-bianchi opened this issue Mar 6, 2022 · 1 comment
Labels
help wanted Extra attention is needed priority:high type:bug Something isn't working

Comments

@Enzo-bianchi
Copy link

Enzo-bianchi commented Mar 6, 2022

Hi,
I found an infinite loop on the refresh method, I added only image layer based on the selected image in the gallery, and when I play the video, after the first layer, I think the refresh is executed and crash

prepare() {
    this.images.forEach(i => {
      this.imgContainer.nativeElement.src = i.webPath
      var imageLayer = new etro.layer.Image({ startTime: this.images.indexOf(i), duration: 1, source: this.imgContainer.nativeElement })
      this.movie.addLayer(imageLayer)
    })
  }
  play() {
      this.movie.play()
  }

image

image

image

image

If I put autoRefresh at false I don't have the error but it doesn't go on the second layer,
The error is on simulator and web

@clabe45
Copy link
Collaborator

clabe45 commented Jul 17, 2022

Removing auto-refresh will solve this problem (along with many, many others). In the meantime, the fix is to add 'active' to etro.effect.Base#publicExcludes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed priority:high type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants