Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onItemClick id is incorrect #69

Closed
davejohncole opened this issue Mar 8, 2014 · 3 comments
Closed

onItemClick id is incorrect #69

davejohncole opened this issue Mar 8, 2014 · 3 comments
Labels
Milestone

Comments

@davejohncole
Copy link
Contributor

https://github.com/etsy/AndroidStaggeredGrid/blob/master/library/src/main/java/com/etsy/android/grid/ExtendableListView.java#L2744

The position argument to performItemClick is offset by mFirstPosition, but the argument passed to adapter.getItemId() is not offset.

I think the line should be:

performItemClick(view, motionPosition + mFirstPosition, adapter.getItemId(motionPosition + mFirstPosition));
@denizmveli
Copy link
Contributor

Care to send a pull request? Would love to give you credit for your fix.

@denizmveli denizmveli added the bug label Apr 6, 2014
@denizmveli denizmveli added this to the 1.0.5 milestone Apr 6, 2014
@davejohncole
Copy link
Contributor Author

I suppose I should learn how to do that...

@denizmveli
Copy link
Contributor

Fixed by #86. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants