Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi eval viewing #462

Closed
nico-abram opened this issue Mar 11, 2019 · 2 comments
Closed

Fix multi eval viewing #462

nico-abram opened this issue Mar 11, 2019 · 2 comments

Comments

@nico-abram
Copy link
Member

You can pretty much never see your own score after clicking someone elses, and sometimes some peoples dont work. Also need to increase precision on ssr in multi(It seems to get rounded. Probably when parsing/creating the json). SSR is sent here: https://github.com/etternagame/etterna/blob/develop/src/NetworkSyncManager.cpp#L1334 which looks fine. Maybe change the 0 in https://github.com/etternagame/etterna/blob/develop/src/NetworkSyncManager.cpp#L819 to 0.0? It's also possible it's getting rounded server-side

@poco0317
Copy link
Member

For offset plot fixing:
Part of the issue lies in desynced indexing between lua and c++.
Refer to mpscoreboard.lua for visual sorting and selecting offset plots.
Refer to ScreenNetEvaluation.cpp for the original and attempted redo of setting the player for offset plots (SetCurrentPlayer(index) and SetCurrentPlayerByName(string))

@nico-abram
Copy link
Member Author

I'm closing this for now. If we find out this still happens under any circumstances we can reopen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants