Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile security and feed-back #66

Open
bjornmolin opened this issue Oct 7, 2024 · 3 comments · May be fixed by #69
Open

Dockerfile security and feed-back #66

bjornmolin opened this issue Oct 7, 2024 · 3 comments · May be fixed by #69
Assignees
@pinamiranda

Comments

@bjornmolin
Copy link

We have some comments on your Dockerfile.

For security

  • You should not run as root in the container
  • The base image contains an unnecessary amount, i.e. an unnecessarily large attack surface

Comments

  • Why do git clone in the Dockerfile on the same repo that Dockerfile resides in?
  • Many things happen in the CMD line that might as well be fixed before e.g. copy file, set environment variable
  • I still think config can be solved better, tried to describe with config with environment variables #49 and it should do e.g. cp /root/secrets/config_secrets.py /root/eudi-srv-web-issuing-eudiw-py/app/app_config/ unnecessary
@janderssonse
Copy link

Plus one to the suggestions above. Have a look at chainguard or alike small images bases: https://images.chainguard.dev/directory/image/python/overview for minimized attack vectors etc.

@janderssonse
Copy link

I also think that #49 should be reopened because it is not solved.

@haeser haeser linked a pull request Oct 22, 2024 that will close this issue
Open
@LuisPereira23
Copy link
Collaborator

@bjornmolin @janderssonse Any further feedback on the PR #69 made by @haeser ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinamiranda pinamiranda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Task/docker improvements haeser/eudi-srv-web-issuing-eudiw-py
4 participants
@bjornmolin @pinamiranda @LuisPereira23 @janderssonse