Buttons of Choice-TaskDialog don't take up available space #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back when I did the PRs #53 and #54 , I only thought I had fixed the horizontal growing issue, but since the instruction of the dialog was as long as one of the buttontexts during testing, I probably didn't notice that the actual container that contains the buttons doesn't grow horizontally. This PR will now fix this, I have tested it with miglayout versions 5.0 and 5.2. And I have fixed the weird indentation of my previous PRs.
akuhtz
pushed a commit
to akuhtz/oxbow
that referenced
this pull request
Nov 22, 2023
Back when I did the PRs eugener#53 and eugener#54 , I only thought I had fixed the horizontal growing issue, but since the instruction of the dialog was as long as one of the buttontexts during testing, I probably didn't notice that the actual container that contains the buttons doesn't grow horizontally. This PR will now fix this, I have tested it with miglayout versions 5.0 and 5.2. And I have fixed the weird indentation of my previous PRs. (cherry picked from commit 453123d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when I did the PRs #53 and #54 , I only thought I had fixed the horizontal growing issue, but since the instruction of the dialog was as long as one of the buttontexts during testing, I probably didn't notice that the actual container that contains the buttons doesn't grow horizontally. This PR will now fix this, I have tested it with miglayout versions 5.0 and 5.2.
And I have fixed the weird indentation of my previous PRs.