-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ships-detection indicator on-the-fly integration #2330
Comments
@dmoglioni Sorry for a bit of confusion on our side. As the algorithm is not producing any output imagery to be "persistent" but just returning the detections geometries and it should be used on the dashboard in a synchronous manner (user of eodash draws area, selects time interval and clicks the "fetch detections"), it will be best (performance-wise) if we remove as much overhead of Headless execution or BYOA of EOxHub as possible, as they are both aimed on async handling. We shall use an existing service (endpoint) that we have developed in other framework, which is capable of returning a value (here GeoJSON geometries) from the process directly in a synchronous manner. Please once they are finished, send us the resulting code + export of the environment used to run the inference (or the requirements.txt) via email. Thanks |
@lubojr CC @aapopescu |
@patrick-griffiths
We do not have GeoJSON directly returned from API, we convert to it after parsing the response. Whichever attributes of the GeoJSON are required to be shown by the client, we shall display on hover... |
Just realized that the above posted is not really helpful, as it involves the structure in which the data are in GeoDB. This is an example of a GeoJSON with features directly used https://github.com/eurodatacube/eodash/blob/staging/app/public/eodash-data/features/E12b/E12b_UK9_20200829.geojson |
that's perfect @lubojr many thanks. |
@patrick-griffiths The properties object can contain any additional metadata to the detections (for example "probability" of valid detection to be shown on hover) or also the scene identifier(s), but I would prefer to instead use the SCENE time of the scene(s) used. If there is a need to subset this input start/end provided by the user on a per detection level (each detection can be extracted from another scene), we can use the same logic like in displaying the wind turbines together with an S2 layer where the TIME information coming from the GeoJSON properties of each detection that the user clicks on. https://gtif.esa.int/explore?x=1823968.87838&y=6094954.34461&z=14.76947&poi=Austria-REP6 |
@aapopescu @lubojr |
@Selimgit @leahsturm @jzvolensky As we do not have other ways of contacting you, could you please let us know if there has been any developments on adding the planned logging of requests of the Vessel inference - https://github.com/ShipDetectionExperts/draft_inference/tree/RACE_DASHBOARD and returning the detected features in EPSG:4326 coordinates? Thanks! |
Hi @lubojr, me and Selim had a chat today. For now, there have been no new developments. We are going to start again and hopefully provide an update on Monday on how things are going. Thank you. |
Hi @lubojr, as promised here is the update on the situation. After our discussion with @Selimgit, we spent a couple of days working on the code. There was no significant progress made. Since you mentioned that you have done this kind of integration before with other scientists, we think it might be easier for you to take over our algorithm and add the required features yourselves. Unfortunately, we are not able to dedicate the time right now to finish anytime soon. Thank you for your understanding. Juraj |
Server side integration was finished. Client integration within RACE dashboard still to finish |
Client side integration is merged to staging and pending a markdown description, to be added to https://github.com/eurodatacube/eodash-assets/blob/main/collections/E13c_ship_detections_algorithm/E13c_ship_detections_algorithm.md |
Client side integration is finished. For possible enhancements, please create a followup issue. |
@aapopescu @lubojr
Here we can track the integration steps of the ships-detection indicator on the dashboard.
We agreed that the most straightforward way to integrate this on-the-fly indicator will be via POST request to a WPS end-point.
Leah, Juraj, Selim will work on:
I discussed this solution with Lubo and we're in line with this way forward. Lubo will verify in parallel with Stephan the setting of a dedicated end-point for this task. As soon as we have access to it we'll start with the testing and integration activity.
The text was updated successfully, but these errors were encountered: