Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from .lua file extension to .luau #341

Closed
wants to merge 1 commit into from

Conversation

itsrenderman
Copy link
Contributor

Declarations:

  • I declare that this contribution was created in whole or in part by me.
  • I declare that I have the right to submit this contribution under the terms of this repository's license and declarations.
  • I understand and agree that this contribution and a record of it are public, maintained permanently, and may be redistributed under the terms of this repository's license.

@itsrenderman itsrenderman changed the title Move from .lua file extension to .luau #334 Move from .lua file extension to .luau Dec 12, 2024
@autonordev
Copy link
Collaborator

autonordev commented Dec 13, 2024

Thanks for the PR, but unfortunately this contribution will not be accepted as noted in ticket 334:

This is not open to contributors, except for the maintainers. A pull request resolving this is not desired; it would cause a lot of noise on the commit history because of how GitHub handles pull requests.

I do already have in mind how and when this change should be done, and there is no particular rush for it.

Was this PR motivated by struggles with GitHub file formatting (i.e. of Luau features)? If so, we could temporarily change the gitattributes to markup/highlight .lua files as Luau.

@autonordev autonordev closed this Dec 13, 2024
@itsrenderman
Copy link
Contributor Author

Ah I understand.

Was this PR motivated by struggles with GitHub file formatting (i.e. of Luau features)? If so, we could temporarily change the gitattributes to markup/highlight .lua files as Luau.

There were no motivations besides simply noticing files were still using the .lua extension instead of .luau while messing around with various things in the code.

I made the file name changes and noticed an issue was open with a matching description. I didn't notice the remark inside the issue stating that a pull request wasn't desired - my apologies.

I do already have in mind how and when this change should be done, and there is no particular rush for it.

Any more information on this?

@itsrenderman itsrenderman deleted the master branch December 27, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from .lua file extensions to .luau
2 participants