From e36166bd18add8e6f5727a2173c5e5405bf382ef Mon Sep 17 00:00:00 2001 From: Evan Lucas Date: Tue, 11 Jul 2017 19:05:39 -0500 Subject: [PATCH] build: codesign tarball binary on macOS Previously, we were signing the binary that was released in the .pkg, but not the binary released in the tarball. PR-URL: https://github.com/nodejs/node/pull/14179 Fixes: https://github.com/nodejs/node/issues/11936 Reviewed-By: Refael Ackermann Reviewed-By: Ben Noordhuis Reviewed-By: Myles Borins Reviewed-By: Gibson Fahnestock Reviewed-By: James M Snell --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 69813e89621e38..6c7986779421b9 100644 --- a/Makefile +++ b/Makefile @@ -808,6 +808,9 @@ $(BINARYTAR): release-only cp README.md $(BINARYNAME) cp LICENSE $(BINARYNAME) cp CHANGELOG.md $(BINARYNAME) +ifeq ($(OSTYPE),darwin) + SIGN="$(CODESIGN_CERT)" PKGDIR="$(BINARYNAME)" bash tools/osx-codesign.sh +endif tar -cf $(BINARYNAME).tar $(BINARYNAME) $(RM) -r $(BINARYNAME) gzip -c -f -9 $(BINARYNAME).tar > $(BINARYNAME).tar.gz