Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid spec implementation #160

Closed
delaneyj opened this issue Feb 16, 2022 · 0 comments
Closed

Invalid spec implementation #160

delaneyj opened this issue Feb 16, 2022 · 0 comments

Comments

@delaneyj
Copy link

Specifically the handling of top level patches

ORIGINAL PATCH RESULT
{"a":"foo"} null null
{"a":"foo"} "bar" "bar"

I noticed in fact that you had commented out the test cases from the RFC and made extra tests to view these as errors. PR to match the spec incoming.
delaneyj added a commit to delaneyj/json-patch that referenced this issue Feb 16, 2022
@delaneyj
Addresses evanphx#160
330e04d
howardjohn added a commit to howardjohn/istio that referenced this issue Mar 5, 2024
@howardjohn
jsonpatch evanphx/json-patch#160
42f692e
howardjohn added a commit to howardjohn/istio that referenced this issue Mar 6, 2024
@howardjohn
jsonpatch evanphx/json-patch#160
8a60ad6
istio-testing pushed a commit to istio/istio that referenced this issue Mar 6, 2024
@howardjohn
bump go.mod dependencies (#49702)
5ae85c6 
* bump go.mod dependencies

* jsonpatch evanphx/json-patch#160

* zap uber-go/zap#1369

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delaneyj