according to RFC6902 JSON patch, replace operation should fail if path not exist before

[jerreli]

This issue is the same as the previous issues(#18 and #40).
According to RFC6902 JSON patch, replace operation should fail if path not exist before. From issue#40, the auther may have merged updated code. But now when I compare codes in branch master or tag 4.2.0, I find that the place that should be updated is not updated. Does the author have other concerns? Expect the author to update the code as soon as possible~~

code in branch master and tag 4.2.0 in method replace:

_, ok := con.get(key)
if ok != nil {
	return fmt.Errorf("jsonpatch replace operation does not apply: doc is missing key: %s", path)
}

code may be merged in method replace:

val, ok := con.get(key)
if val == nil || ok != nil {
	return fmt.Errorf("jsonpatch replace operation does not apply: doc is missing key: %s", path)
}

[evanphx]

That code doesn't work, it will fail things that should pass today. Can you provide an example of a patch that doesn't work right?

[Loushu]

https://play.golang.org/p/gJUZb4dNy99

Expected result: failure to apply patch/panic
Actual result:
Original document: { "Metadata": { } }
Modified document: {"Metadata":{"key1":"val1"}}

[evanphx]

Closed as stale.