-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esbuild tries to resolve wrong css file name in any node_module folder with an upper case .tsx-component #3341
Comments
Please provide a way to reproduce the issue. You have not provided enough information here. Marking this issue as |
Sure, you can try this repo I made to show the issue https://github.com/jonasem/esbuild-component-css-bug Be sure to do npm install or npm ci and then run postinstalll |
You can enable
So here are 2 things:
|
Thank you for the insight into how to debug this issue. So I didn't expect this behavior, but it make sense when I see the error. Renaming the file to uppercase gave an error during runtime which also makes sense with the given verbose log.I hope I don't have to import typescript files by giving the full extension though, esbuils didn't do that before in this case. |
The resolver correctly works back at version 0.17.19 repl. So I guess this is a bug introduced in 0.18. I guess this was added in this commit, where esbuild should prefer .js files over .ts files in node_modules. However that commit also sorts .css before .ts, that's why the CSS file was chosen. It should work by changing the orders, however the case-insensitive problem still exists. |
Don't really know what more to make of this now. I wrote some tests in I only got a failing test on this, and no solution. But I suspect a Basically I would propose a change to resolve .css after .ts in node_modules, something along the lines of: diff --git a/internal/resolver/resolver.go b/internal/resolver/resolver.go
index 11647c6e..37185216 100644
--- a/internal/resolver/resolver.go
+++ b/internal/resolver/resolver.go
@@ -252,7 +252,7 @@ func NewResolver(call config.APICall, fs fs.FS, log logger.Log, caches *cache.Ca
// for imports of files inside of "node_modules" directories
nodeModulesExtensionOrder := make([]string, 0, len(options.ExtensionOrder))
for _, ext := range options.ExtensionOrder {
- if loader, ok := options.ExtensionToLoader[ext]; !ok || !loader.IsTypeScript() {
+ if loader, ok := options.ExtensionToLoader[ext]; !ok || !loader.IsTypeScript() || !loader.IsCSS() {
nodeModulesExtensionOrder = append(nodeModulesExtensionOrder, ext)
}
}
@@ -261,6 +261,11 @@ func NewResolver(call config.APICall, fs fs.FS, log logger.Log, caches *cache.Ca
nodeModulesExtensionOrder = append(nodeModulesExtensionOrder, ext)
}
}
+ for _, ext := range options.ExtensionOrder {
+ if loader, ok := options.ExtensionToLoader[ext]; ok && loader.IsCSS() {
+ nodeModulesExtensionOrder = append(nodeModulesExtensionOrder, ext)
+ }
+ }
// Generate the condition sets for interpreting the "exports" field
esmConditionsDefault := map[string]bool{"default": true} @evanw Is there anything I can do to help along with this issue? |
Hi, |
After upgrading esbuild 0.17 -> 0.19 we experienced a weird behavior where esbuild will try to resolve .css-files for components in node_modules even though they are not imported, just merely by beeing on the disk.
We recreated this in a tiny project only installing react@18 and esbuild@0.19 and adding a folder in node_modules like this:
The error output is:
Could not read from file: /home/jonas/tmp/esbuild-bug/node_modules/foo/bar/A.css
Note that it looks for a big-letter A.css, while we have a small one, and the kicker is, it's not ever imported anywhere.
We tested this multiple times, just making a lower-Pascal-case css file matching an upper case .tsx file triggers this error.
The text was updated successfully, but these errors were encountered: