Fix/react peer conflicts #850
Conversation
🦋 Changeset detectedLatest commit: 3d0350a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
XaaXaaX
force-pushed
the
fix/react-peer-conflicts
branch
4 times, most recently
from
ac15249
to
e2e755c
Compare
|
Yeah all these react peer conflicts from spotlight are slightly annoying. I just tested locally and things to work with this, but I'm not sure if we have any side effects introducing this? Any thoughts @carlosallexandre ? |
I did also a walkthrough and sound promising but you know , nothing clear in JS ecosystem :D |
|
LGTM, But if you are afraid, we can place some e2e tests. I setup the playwright for e2e tests right now - #873. |
XaaXaaX
force-pushed
the
fix/react-peer-conflicts
branch
3 times, most recently
from
439764a
to
9c2a0c1
Compare
XaaXaaX
force-pushed
the
fix/react-peer-conflicts
branch
from
9c2a0c1
to
e2f8f1c
Compare
Motivation
EC uses many dependent packages and we see lots of verbose warnings in CI
We can override the react peers to use the project react installed version
Caution
This need to be tested and we need to validate if all parts of project are working