Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic Entry Point Routing #2825

Closed
tn3rb opened this issue May 13, 2020 · 1 comment
Closed

Add Dynamic Entry Point Routing #2825

tn3rb opened this issue May 13, 2020 · 1 comment

Comments

@tn3rb
Copy link
Member

tn3rb commented May 13, 2020

  • currently webpack uses a hardcoded entry point in config/webpack.config.js

  • this is fine atm because we are currently only using React for the event editor

  • eventually we will begin to convert other admin pages (as well as frontend elements) to use React + AGQL

  • before this happens we will need to know how we are going to handle routing

  • ideally, we will:

    • dynamically route all requests through a single webpack entry to the appropriate UI

    • lazy load components accordingly

    • dynamically fetch data that has been preloaded into the DOM (likely nothing any more special that what we are doing already is needed here, but some logic could potentially be abstracted and shared better)

@nicolad
Copy link
Contributor

nicolad commented May 14, 2020

indeed, we will able to take advantage of federated modules when CRA will update to webpack 5, otherwise we will have to spend too much time of configuration:

facebook/create-react-app#7929


looking for alternatives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants