Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

Improve console output by adding a progress bar #64

Open
everettraven opened this issue Jan 30, 2022 · 10 comments
Open

Improve console output by adding a progress bar #64

everettraven opened this issue Jan 30, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@everettraven
Copy link
Owner

everettraven commented Jan 30, 2022

Make the console output from the packageless tool look nicer by adding a progress bar using something like pterm/pterm when installing, uninstalling, and upgrading pims

@everettraven
Copy link
Owner Author

@felixlevert would you like to take this one?

@felixlevert
Copy link
Contributor

I'd love to! Pretty busy early this week but I'll get on it whenever I can

@everettraven
Copy link
Owner Author

@felixlevert Sounds good! I'll go ahead and assign this issue to you, and take as long as you need

@everettraven everettraven added the enhancement New feature or request label Jan 30, 2022
@everettraven
Copy link
Owner Author

@felixlevert I just wanted to check in. How is this issue coming along?

@felixlevert
Copy link
Contributor

Hey, sorry things have been busy lately. I did spend some time working on this but got stuck on how to extract the output from the ReadCloser object that Docker's ImagePull function returns. I have that part mostly figured out now, but still needs some work and then need to implement the actual progress bar. If you wish to take over this issue that's fine as I'm quite busy with school and would only get a little bit of time to work on this each week.

@everettraven
Copy link
Owner Author

@felixlevert No worries, I completely understand being busy with school as I recently graduated myself. I mostly just wanted to check in and see if this was something you are still interested in taking on. I am happy to keep it assigned to you if you are working on it, but I will likely check in every once in a while because I don't want the issue to become stale.

As far as the ReadCloser object is concerned, I just merged in PR #68 that stops the Docker ImagePull function output from being copied to STDOUT.

I also did some thinking and a spinner may potentially be a better implementation than a progress bar since the number of steps in the installation of a pim can vary based on some various configuration settings. It should make the implementation easier while still providing the value I had originally intended a progress bar to bring.

@everettraven
Copy link
Owner Author

For a spinner it may be worth it to take a look into using charmbracelet/bubbletea and charmbracelet/bubbles

These seem to be much more customizable than the pterm/pterm library mentioned in my first issue comment

@felixlevert
Copy link
Contributor

Great, I'll take a look, thanks.

@felixlevert
Copy link
Contributor

@everettraven Hi, I apologize but I don't think I'll have time to get this done in the end. I'm spreading myself a bit too thin between various commitments currently and need to focus my efforts on school and another project.

Sorry about that, and I hope to contribute more in the future!

@everettraven
Copy link
Owner Author

@felixlevert No worries, thanks so much for the effort that you have put into this and for your previous contributions!

I hope that your schooling and other project goes well!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants