Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes when the checksum doesn't match #28

Open
Pretzelek opened this issue Nov 7, 2021 · 0 comments
Open

App crashes when the checksum doesn't match #28

Pretzelek opened this issue Nov 7, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Pretzelek
Copy link

Duplication steps:
run
C:\Program Files (x86)>pynps -D -zip -c psv -r jap _all

Enter the number for what you want to download, you can enter multiple numbers using commas: 2205-2206

App will try to download the 2205th entry:

[SEARCH] you're going to download the following files:
2205) PSV | PCSG01116 | JAP | DLC | 探索者たちの口伝集 [ 100 KiB]
2206) PSV | PCSG01116 | JAP | DLC | 追加クエスト『経験値どっさりクエスト』 [ 100 KiB]
Download files? [y/n]: y

[DOWNLOAD] 探索者たちの口伝集 (JP) [PCSG01116] for PSV
JP0106-PCSG01116_00-ADVSYSTEM0000001_bg_1_f5f2e3ae4bdc667bf29f992d933ad6c24e3ce 100%

[CHECKSUM] checksum not matching, pkg file is probably corrupted, delete it at your download folder and redownload the pkg
[CHECKSUM] corrupted file location: G:/Games/pynps/PKG/PSV/DLCS/JP0106-PCSG01116_00-ADVSYSTEM0000001_bg_1_f5f2e3ae4bdc667bf29f992d933ad6c24e3cedd4.pkg

Done! <- app stops, doesn't try to download 2206

This is caused by break in the cli.py file:
if sha256_dl != sha256_exp:
loc = f"{DLFOLDER}/PKG/{i['System']}/{i['Type']}/{i['PKG direct link'].split('/')[-1]}"
printft(HTML("[CHECKSUM] checksum not matching, pkg file is probably corrupted, delete it at your download folder and redownload the pkg"))
printft(HTML("[CHECKSUM] corrupted file location: %s") %loc)
break # skip file

Without that break, app fails gracefully and continues processing.

@evertonstz evertonstz added the bug Something isn't working label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants