Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer proguard rule is missing #30

Closed
ghost opened this issue Jul 15, 2016 · 2 comments
Closed

Consumer proguard rule is missing #30

ghost opened this issue Jul 15, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 15, 2016

Consumer proguard rule is missing for current packaging. I suggest that we should add consumer proguard rule to the package.

Readme.md already states that users should exclude JavaScriptInterface from proguard. This has two problems:

  1. Needs attention from library users. Direct user of this library, or maintainers who depend on this library could forget or skip to add these rules in their consumer proguard rules.
  2. Needs further attention from library users who depend on downstream projects of this library. It takes significant effort to figure out what package did mistake in the dependency path to this library.
@evgenyneu
Copy link
Owner

Hi @cyluss, thank you very much for the tip! I did not know that was possible to supply a proguard file with the library. This is really handy. I have done that and released a new version v1.0.7. Let me know if it does not work for you.

@evgenyneu
Copy link
Owner

Closing the issue, feel free to open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant