Node command not found

[vanyauhalin]

After upgrading from v0.7.7 to v1.0.4, lefthook stopped resolving module paths. Maybe I'm missing something.

[vanyauhalin]

The same problem when migrating to v0.8.0.

[mrexox]

Hey @vanyauhalin ! Could you tell about your nodejs installation? Do you update PATH env in .bashrc to point to node? I think this is crucial for understanding the reasons of this bug 🤔

[vanyauhalin]

At first, I thought that maybe this is the fnm changing $PATH and because of it node command are not found, but no. I'm attaching a little more detailed command run history.

fish, fnm, lefthook v0.7.7

~/Documents/development/self/lefthook-command-0.7.7 on main
$ node -v
v18.4.0
~/Documents/development/self/lefthook-command-0.7.7 on main
$ fnm current
system
~/Documents/development/self/lefthook-command-0.7.7 on main
$ pnpm i
Packages: +83
~/Documents/development/self/lefthook-command-0.7.7 on main
$ sh node_modules/.bin/lefthook install
SYNCING lefthook.yml
SERVED HOOKS: pre-commit, prepare-commit-msg

~/Documents/development/self/lefthook-command-0.7.7 on main
$ vim src.js
~/Documents/development/self/lefthook-command-0.7.7 on main
$ git add src.js
~/Documents/development/self/lefthook-command-0.7.7 on main
$ git commit -m 'should be failed'
Lefthook v0.7.7
RUNNING HOOKS GROUP: pre-commit

  EXECUTE > lint
 
/Users/vanyauhalin/Documents/development/self/lefthook-command-0.7.7/src.js
  1:13  error  Strings must use singlequote  quotes

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.



SUMMARY: (done in 0.45 seconds)
🥊  lint

~/Documents/development/self/lefthook-command-0.7.7 on main
$ echo $PATH
/Users/vanyauhalin/Library/Caches/fnm_multishells/7854_1662306441420/bin /opt/homebrew/bin /opt/homebrew/sbin /opt/homebrew/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /Library/Apple/usr/bin
~/Documents/development/self/lefthook-command-0.7.7 on main
$ ps
  PID TTY           TIME CMD
 7844 ttys000    0:01.68 -fish

zsh, lefthook v0.7.7

~/Documents/development/self/lefthook-command-0.7.7 on main
$ node -v
v18.4.0
~/Documents/development/self/lefthook-command-0.7.7 on main
$ fnm current 
error: `fnm env` was not applied in this context.
~/Documents/development/self/lefthook-command-0.7.7 on main
$ pnpm i
Packages: +83
~/Documents/development/self/lefthook-command-0.7.7 on main
$ sh node_modules/.bin/lefthook install
SYNCING lefthook.yml
SERVED HOOKS: pre-commit, prepare-commit-msg

~/Documents/development/self/lefthook-command-0.7.7 on main
$ vim src.js
~/Documents/development/self/lefthook-command-0.7.7 on main
$ git add src.js
~/Documents/development/self/lefthook-command-0.7.7 on main
$ git commit -m 'should be failed'
Lefthook v0.7.7
RUNNING HOOKS GROUP: pre-commit

  EXECUTE > lint
 
/Users/vanyauhalin/Documents/development/self/lefthook-command-0.7.7/src.js
  1:13  error  Strings must use singlequote  quotes

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.



SUMMARY: (done in 0.50 seconds)
🥊  lint

~/Documents/development/self/lefthook-command-0.7.7 on main
$ echo $PATH
/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin
~/Documents/development/self/lefthook-command-0.7.7 on main
$ ps
  PID TTY           TIME CMD
 8647 ttys002    0:00.15 -zsh

fish, fnm, lefthook v0.8.0

~/Documents/development/self/lefthook-command-0.8.0 on main
$ node -v
v18.4.0
~/Documents/development/self/lefthook-command-0.8.0 on main
$ fnm current
system
~/Documents/development/self/lefthook-command-0.8.0 on main
$ pnpm i
Packages: +83
~/Documents/development/self/lefthook-command-0.8.0 on main
$ sh node_modules/.bin/lefthook install
SYNCING lefthook.yml
SERVED HOOKS: pre-commit, prepare-commit-msg

~/Documents/development/self/lefthook-command-0.8.0 on main
$ vim src.js
~/Documents/development/self/lefthook-command-0.8.0 on main
$ git add src.js
~/Documents/development/self/lefthook-command-0.8.0 on main
$ git commit -m 'should be failed'
Lefthook v0.8.0
RUNNING HOOKS GROUP: pre-commit

  EXECUTE > lint
 sh: eslint: command not found


SUMMARY: (done in 0.01 seconds)
🥊  lint

~/Documents/development/self/lefthook-command-0.8.0 on main
$ echo $PATH
/Users/vanyauhalin/Library/Caches/fnm_multishells/7854_1662306441420/bin /opt/homebrew/bin /opt/homebrew/sbin /opt/homebrew/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /Library/Apple/usr/bin
~/Documents/development/self/lefthook-command-0.8.0 on main
$ ps
  PID TTY           TIME CMD
 7844 ttys000    0:02.11 -fish

zsh, lefthook v0.8.0

~/Documents/development/self/lefthook-command-0.8.0 on main
$ node -v
v18.4.0
~/Documents/development/self/lefthook-command-0.8.0 on main
$ fnm current 
error: `fnm env` was not applied in this context.
~/Documents/development/self/lefthook-command-0.8.0 on main
$ pnpm i
Packages: +83
~/Documents/development/self/lefthook-command-0.8.0 on main
$ sh node_modules/.bin/lefthook install
SYNCING lefthook.yml
SERVED HOOKS: pre-commit, prepare-commit-msg

~/Documents/development/self/lefthook-command-0.8.0 on main
$ vim src.js
~/Documents/development/self/lefthook-command-0.8.0 on main
$ git add src.js
~/Documents/development/self/lefthook-command-0.8.0 on main
$ git commit -m 'should be failed'
Lefthook v0.8.0
RUNNING HOOKS GROUP: pre-commit

  EXECUTE > lint
 sh: eslint: command not found


SUMMARY: (done in 0.01 seconds)
🥊  lint

~/Documents/development/self/lefthook-command-0.8.0 on main
$ echo $PATH
/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin
~/Documents/development/self/lefthook-command-0.8.0 on main
$ ps
  PID TTY           TIME CMD
 8647 ttys002    0:00.25 -zsh

$ where node 
/opt/homebrew/bin/node

By the way, if you explicitly specify in the configuration where to run the command, then everything will work.

pre-commit:
  commands:
    lint:
      glob: "*.js"
      run: sh node_modules/.bin/eslint {staged_files}

[mrexox]

Hmm, so node_modules/.bin/ is dynamically added to PATH right? Is it pnpm, or fnm magic? Even with v0.7.7 version but without pnpm and fnm I can't run eslint. I guess in this case you rely on a dev environment a lot.

Can you provide the tweaks for fnm and pnpm? Maybe they add something in ~/.zshrc? Maybe they change the way cd behaves or something like that? Sorry for the long answering, but it's just hard for me to reproduce this without this context.

[thoroc]

Sorry I see that this discussion has been closed, however I've came across this behaviour where lefthook wouldn't find the binaries unless giving the path from the root of the project directory. I have noticed though that using npm you can do the following: npm run <script> where the script might be

{
  "script": {
    "format": "prettier --write --no-wrap always",
  }
}