patch to make lib work in IE7/8 #37
Conversation
|
+1 for this. |
| } | ||
| var isArray = Array.isArray || function(obj) { | ||
| return Object.prototype.toString.call(obj) == '[object Array]'; | ||
| }; |
There was a problem hiding this comment.
This is the only part of this patch that looks fishy. What part of this wasn't unchanged in IE8?
There was a problem hiding this comment.
Not quite sure. I seem to remember isArray was problematic in IE, so I looked to userscore.js to see how they did it.
|
Pushed in 69c5107. Had to change a few things to get test passing. Turns out my The |
|
line: 563 |
|
Thanks - fixed the one too. Should really test this in IE's myself at some point :/ |
Just sharing a patch... markdown.js was failing in IE7/8 on a project I've been working on. I had to quickly make some patches for IE7/8 users because a js error was being thrown: http://dl.dropbox.com/u/385855/Screenshots/8k3z.png
Please note that the following tests are not passing (mostly edge cases). I've not yet had the time to fix but I could try. Please let me know if you have any suggestions as to how I could refactor to get everything green again?
https://gist.github.com/5cddc20d3bb395698a84
Thanks for the great library!