Enable spaces in a link/image url #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm interesting one. The original markdown parser didn't accept this, nor do about half the other parsers covered by this babelmark: Spaces in URLs are an abomination but that's a whole other issue :) |
|
Afaik GitHub uses for redcarpet for its Markdown conversion. In my case I'm linking to local files on a desktop computer's file system. So it's kinda ok to use spaces in links, but of course those links and files with spaces get never deployed into the wild ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the regular expression for handling links and images, whitespaces are now allowed in a link url or image url. GitHub allows this, so it seems legit to change…
[link text](Link to file/Lorem Ipsum.txt "Alt2")is [link text](Link to file/Lorem Ipsum.txt)