Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: don't support tx batch sending #896

Closed
yihuang opened this issue Jan 13, 2022 · 3 comments · Fixed by #901
Closed

Problem: don't support tx batch sending #896

yihuang opened this issue Jan 13, 2022 · 3 comments · Fixed by #901

Comments

@yihuang
Copy link
Contributor

yihuang commented Jan 13, 2022

Proposal: don't support tx batch sending

Current behavior:

The client wants to send multiple transactions concurrently and expects them to be included in the block successfully eventually.
The problem is checkTx reject immediately if the nonce check failed, so if transactions from the same sender with increasing nonce arrived at the node in the wrong order, they'll be rejected.
To support this we can either:

  • wait for abci++ to support sth similar to go-ethereum's non-executable transaction queue in tendermint
  • support multiple MsgEthereumTx in the same tx.

In option 2 we need to be able to query eth transaction information by eth tx hash, currently we do that with /tx_search?query="ethereum_tx.ethereumTxHash=$ETH_TX_HASH", in batch tx case, we need to further iterate the result list to find the msg result, should be doable though.

Desired behavior: support multiple MsgEthereumTx in the same tx.

Use case: client send batch transactions

Requests may be closed if we're not actively planning to work on them.

@fedekunze
Copy link
Contributor

I think we can support multiple MsgEthereumTx (option 2) in the same tx now. We should check that the nonces are increasing (+1) too

@fedekunze
Copy link
Contributor

fedekunze commented Jan 13, 2022

@yihuang if you are planning to work on this maybe we can add it to v0.10

@yihuang
Copy link
Contributor Author

yihuang commented Jan 13, 2022

@yihuang if you are planning to work on this maybe we can add it to v0.10

yes, I'm working on this one.

@yihuang yihuang mentioned this issue Jan 13, 2022
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants