This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-facs
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
July 21, 2022 01:06
yihuang
reviewed
Jul 21, 2022
yihuang
reviewed
Jul 21, 2022
yihuang
reviewed
Jul 21, 2022
yihuang
suggested changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left small cleanup suggestions.
fedekunze
reviewed
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crypto-facs can you move the tests to the existing tests/
directory?
Co-authored-by: yihuang <huang@crypto.com>
yihuang
reviewed
Jul 25, 2022
yihuang
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fedekunze
approved these changes
Jul 25, 2022
facs95
pushed a commit
that referenced
this pull request
Aug 12, 2022
* first pass * latest * working tests * github actions * remove unnecessary change * remove unnecessary steps * remove unnecessary import * remove unnecessary change * Update .github/workflows/test.yml Co-authored-by: yihuang <huang@crypto.com> * update .gitignore * update github actions * change evm denomination * change evm denomination * send tests to tests folder * Delete result * update go version Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Aug 17, 2022
* first pass * latest * working tests * github actions * remove unnecessary change * remove unnecessary steps * remove unnecessary import * remove unnecessary change * Update .github/workflows/test.yml Co-authored-by: yihuang <huang@crypto.com> * update .gitignore * update github actions * change evm denomination * change evm denomination * send tests to tests folder * Delete result * update go version Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain
pushed a commit
to PundiAI/ethermint
that referenced
this pull request
Nov 17, 2022
* first pass * latest * working tests * github actions * remove unnecessary change * remove unnecessary steps * remove unnecessary import * remove unnecessary change * Update .github/workflows/test.yml Co-authored-by: yihuang <huang@crypto.com> * update .gitignore * update github actions * change evm denomination * change evm denomination * send tests to tests folder * Delete result * update go version Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 60598ab)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started migrating some parts from the setup @yihuang had done in cronos to better test RPC endpoints with multiple configurations.
Tests are written in python to take advantage of pystarport for node configuration and also because of the extensive w3 library support for easy testing.
Nix
was used to manage reproducible builds and easy composability of dependencies.This configurations currently allows to setup a basic ethermint and geth node and expect tests to pass on both networks. At the moment I just added a super simple
test_basic
to prove the concept as the configuration itself is very complex.Openning as a first draft to get some comments on it and as a foundation on which to build a robust test suite to maintain better reliabily on the RPC nodes. I will add extensive tests once this PR is merged and also other several configurations on which to tests like
pruned_nodes
, which should be straightforward with this suite as it has been done in Cronos.Big shoutout to @yihuang for setting this up
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)