Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fixes for 19.0.1 #1305

Merged
merged 4 commits into from
Aug 26, 2022
Merged

fixes for 19.0.1 #1305

merged 4 commits into from
Aug 26, 2022

Conversation

ramacarlucho
Copy link
Contributor

Closes: #1247

Description

Minor fixes for eip712.
Support for optional parameters.
Time type
Support for basic types arrays.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@facs95 facs95 merged commit c9fe1d1 into main Aug 26, 2022
@facs95 facs95 deleted the rama/eip712-fixes branch August 26, 2022 18:25
facs95 pushed a commit that referenced this pull request Aug 26, 2022
* fixes for 19.0.1

* changelog

* changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fedekunze pushed a commit that referenced this pull request Aug 27, 2022
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP712 doesn't support optional parameters
3 participants