Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: parse for websocket connID #1685

Closed
wants to merge 13 commits into from
Closed

fix: parse for websocket connID #1685

wants to merge 13 commits into from

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Feb 25, 2023 •
edited
Loading

Closes: crypto-org-chain/cronos#891

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe marked this pull request as ready for review February 25, 2023 14:38
@mmsqe mmsqe requested a review from a team as a code owner February 25, 2023 14:38
@mmsqe mmsqe requested review from Vvaradinov and GAtom22 and removed request for a team February 25, 2023 14:38
GAtom22
GAtom22 suggested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmsqe !! Could you please address the Lint / Check gomod2nix.toml file is up to date check that is failing?

GAtom22
GAtom22 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mmsqe !!

@mmsqe mmsqe requested review from GAtom22 and removed request for Vvaradinov March 24, 2023 01:32
@mmsqe mmsqe mentioned this pull request Apr 27, 2023
Merged
11 tasks
mmsqe added a commit to crypto-org-chain/ethermint that referenced this pull request May 15, 2023
@mmsqe
fix: parse for websocket connID (backport: evmos#1685) (#239)
bad31ab 
* fix parse for websocket connID

* update doc
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

mmsqe added a commit to mmsqe/ethermint that referenced this pull request Jun 14, 2023
@mmsqe
fix: parse for websocket connID (backport: evmos#1685) (#239)
79c7676 
* fix parse for websocket connID

* update doc
@mmsqe mmsqe mentioned this pull request Jun 14, 2023
Merged
11 tasks
mmsqe added a commit to crypto-org-chain/ethermint that referenced this pull request Jun 14, 2023
@mmsqe
fix: parse for websocket connID (backport: evmos#1685) (#239) (#273)
266040f 
* fix parse for websocket connID

* update doc
@github-actions github-actions bot closed this Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GAtom22 GAtom22 Awaiting requested review from GAtom22

Assignees
No one assigned
Labels
Status: Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json-rpc ws protocol : invalid type for connection ID: string
2 participants
@mmsqe @GAtom22