Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Support unprotected txs #1815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdehoog
Copy link

@mdehoog mdehoog commented Jul 25, 2023

Description

There is a flag for enabling pre-EIP-155 transactions:

JSONRPCAllowUnprotectedTxs = "json-rpc.allow-unprotected-txs"

Currently that flag is not read when creating the configuration, which this PR fixes.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work. (minor bug fix)
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mdehoog mdehoog marked this pull request as ready for review July 25, 2023 18:22
@mdehoog mdehoog requested a review from a team as a code owner July 25, 2023 18:22
@mdehoog mdehoog requested review from Vvaradinov and MalteHerrmann and removed request for a team July 25, 2023 18:22
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

@mdehoog
Copy link
Author

mdehoog commented Sep 11, 2023

cc @Vvaradinov @MalteHerrmann

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant