-
Notifications
You must be signed in to change notification settings - Fork 562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minor suggestions only. Can you add a changelog entry and create an issue to write a test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
done |
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
===========================================
+ Coverage 46.90% 67.57% +20.67%
===========================================
Files 43 9 -34
Lines 2889 808 -2081
===========================================
- Hits 1355 546 -809
+ Misses 1463 238 -1225
+ Partials 71 24 -47
|
0c4e6b4
to
1f29322
Compare
@yihuang can you fix the build errors? 🙏 |
Closes #67 Update ethereum/rpc/namespaces/eth/api.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Update ethereum/rpc/namespaces/eth/api.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> change GetTxByEthHash to method add entry to changelog
fixed and rebased. |
Closes #67
Description
SendTransaction
return eth tx hash to clientGetTransaction
convert eth hash to tm hash by calling/tx_search
.Verified in external integration test:
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)