This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
evm keeper benchmark #577
Closed
evm keeper benchmark #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit https://dashboard.github.orijtech.com?back=0&pr=577&remote=false&repo=tharsis%2Fethermint to see benchmark details. |
fedekunze
reviewed
Sep 21, 2021
| nonce := suite.app.EvmKeeper.GetNonce(suite.address) | ||
| msg := evmtypes.NewTx(suite.app.EvmKeeper.ChainID(), nonce, &common.Address{}, big.NewInt(100), 21000, big.NewInt(1), nil, nil) | ||
| msg.From = suite.address.Hex() | ||
| err := msg.Sign(ethtypes.LatestSignerForChainID(suite.app.EvmKeeper.ChainID()), suite.signer) |
There was a problem hiding this comment.
you can move the LatestSignerForChainID outside the for loop
Merged
|
redo PR in #586 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some benchmark tests for
erc20 token tx,statedb, andstate_transitionFor contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)