Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: ForEachStorage sematic not compatible with go-ethereum #798

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 30, 2021

Solution:

  • reversed the semantic of return value of the callback function.

ref: https://github.com/ethereum/go-ethereum/blob/master/core/state/statedb.go#L637

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- reversed the semantic of return value of the callback function.
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, can you add a bugfix changelog entry?

@yihuang
Copy link
Contributor Author

yihuang commented Nov 30, 2021

Good catch, can you add a bugfix changelog entry?

done

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #798 (69fd5c0) into main (5a49153) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files          73       73           
  Lines        6021     6021           
=======================================
  Hits         3446     3446           
  Misses       2375     2375           
  Partials      200      200           
Impacted Files Coverage Δ
x/evm/keeper/keeper.go 75.86% <0.00%> (ø)
x/evm/keeper/statedb.go 73.26% <100.00%> (ø)

@fedekunze fedekunze enabled auto-merge (squash) November 30, 2021 10:27
@fedekunze fedekunze added the automerge Automatically merge PR once all prerequisites pass. label Nov 30, 2021
@fedekunze fedekunze merged commit e6d0eff into evmos:main Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants