Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Update base fee in begin blocker #822

Merged
merged 6 commits into from
Dec 15, 2021
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Dec 10, 2021

Closes: #820

Description

Move base fee update from end blocker to begin blocker, to keep it compliant with go-ethereum.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #822 (eb6f510) into main (423944b) will decrease coverage by 0.26%.
The diff coverage is 66.66%.

❗ Current head eb6f510 differs from pull request most recent head b813245. Consider uploading reports for the commit b813245 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   57.31%   57.05%   -0.27%     
==========================================
  Files          72       72              
  Lines        5984     5985       +1     
==========================================
- Hits         3430     3415      -15     
- Misses       2357     2373      +16     
  Partials      197      197              
Impacted Files Coverage Δ
x/feemarket/keeper/eip1559.go 94.54% <ø> (ø)
x/feemarket/keeper/abci.go 46.66% <50.00%> (-53.34%) ⬇️
app/app.go 83.84% <100.00%> (+0.04%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, can you add a changelog entry?

@yihuang
Copy link
Contributor Author

yihuang commented Dec 12, 2021

Ack, can you add a changelog entry?

done

@fedekunze fedekunze enabled auto-merge (squash) December 15, 2021 02:07
@fedekunze fedekunze merged commit 50e4637 into evmos:main Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: base fee is not updated in begin block
2 participants