This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Change evm_hook to use Transaction Receipt #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #849 +/- ##
==========================================
+ Coverage 56.79% 57.18% +0.38%
==========================================
Files 74 74
Lines 6106 6140 +34
==========================================
+ Hits 3468 3511 +43
+ Misses 2433 2423 -10
- Partials 205 206 +1
|
fedekunze
reviewed
Dec 23, 2021
fedekunze
reviewed
Dec 23, 2021
github-actions
bot
added
C:CLI
C:Proto
ramacarlucho
commented
Jan 3, 2022
fedekunze
approved these changes
Jan 3, 2022
yihuang
reviewed
Jan 4, 2022
| } else if commit != nil { | ||
| // PostTxProcessing is successful, commit the cache context | ||
| commit() | ||
| ctx.EventManager().EmitEvents(k.Ctx().EventManager().Events()) |
There was a problem hiding this comment.
hooks execution is moved under the k.WithContext(ctx), this changed the context hooks executed in.
And k.Ctx() is same as ctx here, we'll lose events emitted by hooks, and re-emit events in `ctx.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #ENG-381
Description
Some hooks may need gasUsed by the execution
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)