This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 562
fix: contract address in contract creation receipt is wrong #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
December 21, 2021 09:20
yihuang
changed the title
Problem: contract address in contract creation receipt is wrong
fix: contract address in contract creation receipt is wrong
Dec 21, 2021
yihuang
force-pushed
the
fix-contract-creation
branch
from
December 21, 2021 09:35
65f894c
to
02d4362
Compare
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
==========================================
- Coverage 56.79% 56.77% -0.03%
==========================================
Files 72 72
Lines 6060 6066 +6
==========================================
+ Hits 3442 3444 +2
- Misses 2420 2424 +4
Partials 198 198
|
This was referenced Dec 21, 2021
fedekunze
approved these changes
Dec 21, 2021
yihuang
commented
Dec 22, 2021
yihuang
commented
Dec 22, 2021
yihuang
force-pushed
the
fix-contract-creation
branch
from
December 22, 2021 01:35
25e54f3
to
0cb52bf
Compare
fedekunze
reviewed
Dec 22, 2021
yihuang
force-pushed
the
fix-contract-creation
branch
4 times, most recently
from
December 22, 2021 17:16
e49d221
to
f99d6f2
Compare
yihuang
commented
Dec 22, 2021
Closes: evmos#850 - decrease nonce before evm.create - add unit tests and rpc tests
yihuang
force-pushed
the
fix-contract-creation
branch
from
December 27, 2021 07:52
fc3b346
to
7b78820
Compare
@yihuang can you add a Changelog entry for this fix? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #850
Description
How the nonce is changed:
Two contraints for the design:
ApplyMessage
fails.sender.nonce
should be equal totx.nonce
when callingevm.create
, so the contract address will be correct.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)