Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Add criteria to filter #865

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Add criteria to filter #865

merged 2 commits into from
Dec 31, 2021

Conversation

crypto-facs
Copy link
Contributor

Closes: #792

Description

Criteria's were missing on filter creation


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze
Copy link
Contributor

@crypto-facs can you add a bug fix changelog entry?

@crypto-facs
Copy link
Contributor Author

@crypto-facs can you add a bug fix changelog entry?

Done 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC Filter parameters ignored; events from current block always returned
2 participants