Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pastml should stop with an error when internal node labels are not unique #23

Open
stitam opened this issue Mar 22, 2024 · 1 comment
Open

Comments

@stitam
Copy link

stitam commented Mar 22, 2024

It took me a while to discover that the reason I was getting funky pastml results was that my input tree had redundant internal node labels. While this is clearly a problem with my input data, I would have found it sooner if pastml had given me an informative error saying that I have non-unique internal node labels in my tree. Can such an input validation be added to pastml? FYI, I tested this with pastml v1.9.34, apologies if the issue has been fixed (commit messages did not suggest the issue has been fixed). Thanks, and also many thanks for developing pastml!

@stitam
Copy link
Author

stitam commented Mar 22, 2024

Adding linked issues:

ms609/TreeTools#149

emmanuelparadis/ape#113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant