Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include relevant bootstrap CSS and JS #68

Open
ewels opened this issue Jun 11, 2015 · 4 comments
Open

Include relevant bootstrap CSS and JS #68

ewels opened this issue Jun 11, 2015 · 4 comments
Milestone

Comments

@ewels
Copy link
Owner

ewels commented Jun 11, 2015

Ok, so including the entire bootstrap CSS will break people's websites, but I could make a stripped down version which targets the carousels specifically. Then give the option of including these files.

This would have the added benefit that the carousel could be used on non-bootstrap sites.

@ewels ewels added this to the 2.0 milestone Jun 11, 2015
@RKS213
Copy link

RKS213 commented Sep 24, 2015

Not much but to make this easier you can load a page with just the carousel and nothing else HTML wise and use the Chrome extension "CSS Remove and Combine" and it will pull all CSS used on that page into it's own file for you. Just make sure the carousel is the only thing on the doc and that you're loading all the relevant Bootstrap files and it'll take you five seconds to get the exact styles you need.

Also, it would be wise to make it an option since many users will already be loading Bootstrap.

@ewels
Copy link
Owner Author

ewels commented Sep 28, 2015

Awesome - thanks for the tip @RKS213! I'll definitely use that when I get to this issue.

Yes, this would definitely be an opt-in feature, and a pretty low priority one at that as I expect most users to be using bootstrap already. I just thought that it could open up the plugin to more sites.

For my own reference, I assume that this is the tool you're referring to..

@RKS213
Copy link

RKS213 commented Sep 28, 2015

That is the correct addon I was talking about.

As for myself, I do not need this feature, I was just looking around and somehow managed to come in here. I like using the CDN for bootstrap and would personally want to disable any overriding CSS that might come from a plugin. Just my 2 cents I think you're correct to just require people to use Bootstrap already.

@ewels
Copy link
Owner Author

ewels commented Sep 28, 2015

Yup - would definitely make it turned off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants