Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in a11y #84

Open
ricardomoro opened this issue May 9, 2016 · 4 comments
Open

Error in a11y #84

ricardomoro opened this issue May 9, 2016 · 4 comments

Comments

@ricardomoro
Copy link

This error appears in the accessibility audit tool a11y:

✖ The purpose of each link should be clear from the link text

#cptbc_973 > .left.carousel-control
#cptbc_973 > .right.carousel-control

I'm using Twitter Bootstrap Version 3 output.

@ewels
Copy link
Owner

ewels commented May 9, 2016

Thanks for the report - what would fix it? I notice that the bootstrap docs now have role="button" which isn't in the markup produced by the plugin.. (also screen reader only text)

@ricardomoro
Copy link
Author

I think that besides the role="button", the links need a text content. As you said, a screen reader only text should be sufficient.
Furthermore, aria-hidden="true" must be placed in the glyphicon span, such as the Bootstrap docs shows.

@ewels
Copy link
Owner

ewels commented Aug 17, 2016

Thanks @ricardomoro - I will add these when I next do some work on the plugin (could be while, I haven't actually used it myself for years now). Feel free to open a PR if you'd like to see it added sooner.

Phil

@ricardomoro
Copy link
Author

Ok @ewels, thank you!
I'll do that, as soon as I use the plugin again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants