Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Skip modules with no files from search patterns #1463

Closed
ewels opened this issue Jun 26, 2021 · 0 comments · Fixed by #1500
Closed

Performance: Skip modules with no files from search patterns #1463

ewels opened this issue Jun 26, 2021 · 0 comments · Fixed by #1500
Assignees

Comments

@ewels
Copy link
Member

ewels commented Jun 26, 2021

MultiQC execution runs in a few distinct steps. First, the file-search mechanism finds files based on the search pattern identifiers, then the modules are run.

Currently, I am pretty sure that all modules always run. We could potentially get a small performance improvement by entirely skipping a module if the search pattern returned no files. Each module should be doing very little in this case, so it might not have much effect, but could be an easy thing to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants