Set several modules too-global search patterns to share #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewels
reviewed
Apr 24, 2018
multiqc/utils/search_patterns.yaml
Outdated
| afterqc: | ||
| fn: '*.json' | ||
| contents: 'allow_mismatch_in_poly' | ||
| shared: true |
There was a problem hiding this comment.
This shouldn't be needed, as it also needs the string allow_mismatch_in_poly in the file which should be specific enough (it's not claiming all JSON files).
ewels
added
the
waiting: changes
|
Sorry, had this laying around for a bit tooooo long =/. I agree that making the search-pattern entries more specific via file contents would be the better solution. However, this is not possible for ALL the too-global modules. A balance has been struck in 3086e73. A wise lesson to all tool developers: add some freaking commented header metadata to your output files. |
ewels
removed
the
waiting: changes
|
Great stuff, thank you for this! Relatively minor changes, but could actually solve a lot of "bugs" for a lot of people! 👍 |
ewels
added a commit
that referenced
this pull request
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went over the search_patterns.yaml .
Those modules which entries I thought too global had
shared: trueadded to them in order to prevent them from incorectly claiming a file. Mostly these are entries withfnwithout anycontent.This should reduce the number of times a module eats a log when it's search pattern had a false-positive hit. I don't think this will result in too much of a performance hit.
Cheers