Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untyped decorator issue with rich-click #85

Closed
cheginit opened this issue Aug 3, 2022 · 4 comments
Closed

Untyped decorator issue with rich-click #85

cheginit opened this issue Aug 3, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@cheginit
Copy link

cheginit commented Aug 3, 2022

Click used to have this issue with static type checker:

Untyped decorator makes function "cli" untyped

They addressed this issue but when I switched to using rich-click, I am getting this error message again when running mypy.

@ewels ewels added the good first issue Good for newcomers label Aug 17, 2022
@ewels
Copy link
Owner

ewels commented Aug 17, 2022

I'm not a big mypy user (as in, I've not used it and don't use it) so this isn't a fix that comes easily to me. If you're able to put in a PR to solve the issue, that would be great 🙏🏻

Thanks!

@cheginit
Copy link
Author

Sure, will give it a try!

@dwreeves
Copy link
Collaborator

dwreeves commented Oct 7, 2023

All typing issues should have hopefully been resolved with #126, and will be released in 1.7.

All rich-click decorators will now have full typing parity with click 8.x, meaning if a static type check works in click 8.x then it should also work in rich-click 1.7.

This particular static type checking failure was easy to reproduce on my end, and I have confirmed it has been resolved subsequent to the code changes in #126.

@dwreeves dwreeves closed this as completed Oct 7, 2023
@cheginit
Copy link
Author

cheginit commented Oct 7, 2023

Great, thank you. I will give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants