Add check that decomposition includes qsd2q gates before optimizing them #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pointing this out John. Could you also add jsmallz333 since they originally suggested this fix? |
Co-authored-by: jsmallz333 <90203920+jsmallz333@users.noreply.github.com>
I amended the commit message to tag jsmallz333 |
|
@ewinston This should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR Qiskit#10126 still allows some 2q unitaries to fail. The commit here prevents these (all I know of) failures.
Adds a fix and test for a 2q unitary that failed with on the branch that this PR is made to.