Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP-to-DNS script does not differentiate same MAC addresses on different network domains #50

Closed
KuxaBeast opened this issue Oct 22, 2023 · 4 comments

Comments

@KuxaBeast
Copy link

Instead of properly differentiating between different DHCP network domains and assigning different records for different leases with same MAC addresses, the script ignores other addresses. This feature is particularly useful when using multiple VLANs on devices.

#49 is also affected by this.

@eworm-de
Copy link
Owner

This behavior has historical reasons... Some time ago it was not possible to have different DNS name suffixes for different (DHCP) networks. Support for that was added later.

We should probably change that now... Though care has to be taken in case the DNS name suffix for different networks is still configured to be the same.

@eworm-de
Copy link
Owner

Fixed with 3474b9a.

@KuxaBeast
Copy link
Author

@eworm-de Actually I made the fix as part of #49 already :D. I will check out your changes and perhaps rebase the MR upon it?

@eworm-de
Copy link
Owner

Yes, but it was on top of the IPv6 changes and I preferred some details to have different. For example I decided to go with a comment the can be parsed by $ParseKeyValueStore.

Please test and report back (or prepare patches) if things are still misbehaving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants