Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 in esl-utils]: debounce method is incompatible with async void functions typescript 5 #1954

Open
ala-n opened this issue Sep 25, 2023 · 1 comment
Assignees
Labels
postponed Postponed issue under discussion waits triage Issue that waits to be reviewed and handled

Comments

@ala-n
Copy link
Collaborator

ala-n commented Sep 25, 2023

Input Code

  class Test {
    @decorate(debounce, 100) // TS: type are incompatible
    protected async update(): Promise<void> {
       // ... await
    }
  }

Expected behavior/code
Should wrap async method fine

Environment

  • Webpack 5.88.2 + ts-lader 9.4.4
  • Node 18; npm 8
  • Typescript: 5.2.2
  • Target: ES6

Additional context
Q: is it a valid situation ootb?

@ala-n ala-n added waits triage Issue that waits to be reviewed and handled under discussion labels Sep 25, 2023
@fshovchko fshovchko self-assigned this Jul 3, 2024
@fshovchko fshovchko added the postponed Postponed issue label Jul 8, 2024
@fshovchko
Copy link
Contributor

After discussion with @exadel-inc/esl-core-team, it was decided to postpone the issue.
No simple solution was found, since altering types only would introduce additional issue.
Proposed solutions were considered too heavy and would probably require introduction of another parameter in debounced signature, or altering debouncedSubject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postponed Postponed issue under discussion waits triage Issue that waits to be reviewed and handled
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants