Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all connections are closed on failure #39

Closed
ckunki opened this issue Aug 18, 2023 · 2 comments
Closed

Ensure all connections are closed on failure #39

ckunki opened this issue Aug 18, 2023 · 2 comments
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Aug 18, 2023

Ticket mentioned as "IntRef" reported that when user cancels an SQL query in Exasol database the resulting Hive query does not get canceled.

The current ticket therefore requests to inspect and if possible to improve the connection handling in VSHIVE.
See also ticket exasol/virtual-schema-common-jdbc#151 for improved connection handling in VSCJDBC.

If possible then VSHIVE should ensure that especially in the case of an exception VSHIVE closes all connections.

Acceptance criteria

  1. Connection handling in VSHIVE is analysed and result of analysis is attached or linked to the current ticket
  2. If possible connection handling is improved

See for example HiveSqlDialect.java#L144

@Override
protected RemoteMetadataReader createRemoteMetadataReader() {
    try {
        return new HiveMetadataReader(this.connectionFactory.getConnection(), this.properties);
    } catch (final SQLException exception) {
        throw new RemoteMetadataReaderException(ExaError.messageBuilder("E-VSHIVE-1")
                .message("Unable to create Hive remote metadata reader. Caused by: {{cause|u}}",
                        exception.getMessage()) //
                .toString(), exception);
    }
}
@ckunki ckunki added the refactoring Code improvement without behavior change label Aug 18, 2023
@Shmuma Shmuma self-assigned this Aug 21, 2023
@Shmuma Shmuma self-assigned this Sep 4, 2023
@Shmuma
Copy link
Collaborator

Shmuma commented Sep 11, 2023

All the issues are in shared libs (virtual schema-common-jdbc). All the findings and subsequent task are in this ticket: exasol/virtual-schema-common-jdbc#151

@kaklakariada
Copy link
Collaborator

Reviewed OK. Implementation will be done in follow-up tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

3 participants