Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave connection creation to dialects #26

Closed
redcatbear opened this issue Feb 3, 2020 · 0 comments · Fixed by #27
Closed

Leave connection creation to dialects #26

redcatbear opened this issue Feb 3, 2020 · 0 comments · Fixed by #27
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@redcatbear
Copy link
Collaborator

Situation

At the moment a connection to the remote data source is created regardless of whether we need it or not inside the dialect. This hinders some speedups like caching remote metadata.

Instead of injecting the connection when creating a dialect, we should inject the connection factory, so that the dialect can control whether or not it needs to open a remote connection for a certain task.

For example there is not a single dialect that needs a connection in order to report capabilities.

Acceptance Criteria

  1. VS adapter injects connection factory instead of connection into a dialect.
@redcatbear redcatbear self-assigned this Feb 3, 2020
@redcatbear redcatbear added the refactoring Code improvement without behavior change label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant