Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #46

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Develop #46

merged 3 commits into from
Apr 24, 2020

Conversation

AnastasiiaSergienko
Copy link
Contributor

@AnastasiiaSergienko AnastasiiaSergienko commented Apr 24, 2020 •
edited
Loading

Closes #28, 41, 43, 45

@AnastasiiaSergienko
#41: removed the deleted properties usage (#42)
b476045 
* #41: Removed the deleted properties usage
@AnastasiiaSergienko
Refactoring/43 set mandatory properties (#44)
fe06238 
* #43: set common properties for all dialects in AbstractSqlDialect
* #43: removed `getAggregateFunctionAliases` settings from AbstractDialect
* #43: change an access to the getSupportedProperties to public
@AnastasiiaSergienko
#28: improved data types mapping in BaseColumnMetadataReader (#47)
b4e9d08
@AnastasiiaSergienko AnastasiiaSergienko marked this pull request as ready for review April 24, 2020 10:27
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Apr 24, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

83.9% 83.9% Coverage
0.0% 0.0% Duplication

@AnastasiiaSergienko AnastasiiaSergienko merged commit 84d0b72 into master Apr 24, 2020
This was referenced Apr 24, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morazow morazow morazow approved these changes

Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve types mapping in BaseColumnMetadataReader
2 participants
@AnastasiiaSergienko @morazow