Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update DisplayMode Names + FitContainer to fit the canvas to its parent element and maintain aspect ratio #1928

Merged
merged 10 commits into from
Jun 26, 2021
Merged

feat: Update DisplayMode Names + FitContainer to fit the canvas to its parent element and maintain aspect ratio #1928

merged 10 commits into from
Jun 26, 2021

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jun 18, 2021 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

FitContainer2

Changes:

  • Breaking change to DisplayMode names (sorry but these are really better we promise)
  • Added a new DisplayMode.FitContainer that fits the canvas to its parent element and maintain aspect ratio

@eonarheim eonarheim added the work-in-progress A work in progress pull request, will not be merged until this is removed label Jun 18, 2021
@github-actions github-actions bot added the enhancement Label applied to enhancements or improvements to existing features label Jun 18, 2021
@eonarheim eonarheim changed the title feat: FitContainer DisplayMode to fit the engine viewport to its parent element and maintain aspect ratio feat: Update DisplayMode Names + FitContainer to fit the canvas to its parent element and maintain aspect ratio Jun 19, 2021
@eonarheim eonarheim removed the work-in-progress A work in progress pull request, will not be merged until this is removed label Jun 19, 2021
@eonarheim eonarheim merged commit 3d44272 into main Jun 26, 2021
@eonarheim eonarheim deleted the feature/fit-container branch June 26, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eonarheim