Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top left hamburger button not working #2160

Open
parmentelat opened this issue Jun 11, 2024 · 6 comments
Open

top left hamburger button not working #2160

parmentelat opened this issue Jun 11, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@parmentelat
Copy link

parmentelat commented Jun 11, 2024

Describe the bug

context
I have noticed that my recent builds with jb1 have their "toggle primary sidebar" button no longer working; clicking the button just does almost nothing

expectation
clicking the button used to collapse the left hand side toc pane, leaving more space for the main content

image

instead I am getting this

image

problem
This is a problem for teachers who use the left hand side area to move from one section to the other, but who all the rest of the time need the extra space

Reproduce the bug

I am not sure exactly when this started to happen
I just build my pages the same way as usual, and apparently all my books now exhibit the same behaviour
this being said they all share the same settings and theme, so this is not conclusive
otoh I have at least reproduced the issue after I removed all my styling, so I believe the problem is upstream

I'll keep on investigating though, in order to rule out any misconfiguration on my end
any feedback from others, whether they experience the same or not with a recently created virtualenv with all the latest versions, would be helpful to me in this respect

List your environment

jupyter-book --version

Jupyter Book      : 1.0.0
External ToC      : 1.0.1
MyST-Parser       : 2.0.0
MyST-NB           : 1.1.0
Sphinx Book Theme : 1.1.2
Jupyter-Cache     : 1.0.0
NbClient          : 0.10.0
@parmentelat parmentelat added the bug Something isn't working label Jun 11, 2024
@sbwiecko
Copy link

sbwiecko commented Jun 11, 2024

Following recent changes to my build environment (which included updates to several Python packages), I've encountered a browser console error:

Incorrect use of The label's for attribute doesn't match any element id.

that points to <label class=sidebar-toggle... for="__secondary"...></label>

@parmentelat
Copy link
Author

thanks @sbwiecko, this is helpful; can you confirm if you're experiencing this problem too ?

@sbwiecko
Copy link

sbwiecko commented Jun 11, 2024

I confirm, the toogle button doesn't work since my last build, although it worked perfectly well 2 weeks ago.
image
jupyter-book --version lists the exact same versions as you.

@rowanc1
Copy link
Contributor

rowanc1 commented Jun 12, 2024

I believe it is related to this:
executablebooks/sphinx-book-theme#836

@sbwiecko
Copy link

I believe it is related to this: executablebooks/sphinx-book-theme#836

Thank you @rowanc1 pip install pydata-sphinx-theme<0.15.3 is indeed a temporary fix.

@agoose77
Copy link
Collaborator

This has now been fixed upstream, and will eventually be included in a new Jupyter Book release. I'm going to try and do that today, but it's a fiddly task! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants