🪐 Thebe integration #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejpurves
force-pushed
the
feat/thebe
branch
from
89758c8
to
3b66698
Compare
stevejpurves
force-pushed
the
feat/thebe
branch
from
b636d28
to
0726db6
Compare
stevejpurves
force-pushed
the
feat/thebe
branch
from
62bc3f7
to
bede18a
Compare
stevejpurves
reviewed
Apr 3, 2023
|
Wow, the Thebe support is super exciting. I can't wait to try out this new feature ✨ |
stevejpurves
force-pushed
the
feat/thebe
branch
from
2c133ed
to
b66989c
Compare
* 🔧 Consume new thebe myst frontmatter * 🌎 Default to local server if present in config * 🤖 Use git modules for patches * 🐛 Types * Update packages --------- Co-authored-by: Rowan Cockett <rowanc1@gmail.com>
rowanc1
commented
Apr 26, 2023
Comment on lines
+38
to
+39
| "thebe-core": "^0.1.6", | ||
| "thebe-react": "^0.0.7", |
There was a problem hiding this comment.
@stevejpurves I think it is worth pinning the thebe packages to the same release number?! This is how we are doing it in theme, and is a few less numbers that we have to keep in mind. :)
| @@ -0,0 +1,75 @@ | |||
| function BinderBadgeLogo() { | |||
There was a problem hiding this comment.
In future, I think this can go in icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that updates myst-theme shared packages to add support for
thebeSee also: executablebooks/myst-book-theme#4
TODO: